[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rGb370be37cca7: [CUDA] Allow the new driver to compile CUDA in non-RDC mode (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D129655?vs=44

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009 + // Host-side offloading compilation receives all device-side outputs. Include + // them in the host compilation depending on the target. if ((IsC

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7009 + // Host-side offloading compilation receives all device-side outputs. Include + // them in the host compilation depen

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 updated this revision to Diff 444398. jhuber6 marked an inline comment as done. jhuber6 added a comment. Updating and making suggested changes. I removed the old `fgpu-rdc` in rG6abaa8e2103760025cee76528f555de7cf6698e6

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 marked an inline comment as done. jhuber6 added a comment. It's also worth noting that this doesn't include the `PTX` output for JIT in the fatbinary, it would be relatively easy to include that but I wanted to ask how we should handle that. Comment at: clang/lib/Driv

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

tra added a comment. Nice. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6999 +if (IsRDCMode) + CmdArgs.push_back("-fgpu-rdc"); + } else if (IsCuda && !HostOffloadingInputs.empty() && !IsRDCMode) { This should not be necessary -- we've already add

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6998-6999 +CmdArgs.push_back(CudaDeviceInput->getFilename()); +if (IsRDCMode) + CmdArgs.push_back("-fgpu-rdc"); + } else if (IsCuda && !HostOffloadingInputs.empty() && !IsRDCMode) { ---

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Th