[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9666d2339e5: [clang][dataflow] Generate readable form of boolean values. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 444029. wyt marked an inline comment as done. wyt added a comment. Address comment on renaming parameter. Add const qualifier to BoolValue input to debugString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:33-34 + explicit DebugStringGenerator( + llvm::DenseMap UserSpecifiedAtomNames) + : Counter(0), AtomNames(std::move(UserSpecifiedAtomNames

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443982. wyt added a comment. Move `DebugStringGenerator` class into anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-f

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:28 + +class DebugStringGenerator { +public: This class could be in anonymous namespac

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443968. wyt added a comment. Fix use after move. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-formatted-files.txt clang/include/clang

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443940. wyt marked 10 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-form

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:24-25 +namespace dataflow { +/// Utility functions which return a string representation for a boolean value +/// `B`. +/// Comment at: clan

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443914. wyt added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-formatted-files.txt clang/include/clang/Analys

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443905. wyt added a comment. Extract recursion into boolean subvalues into separate statements to enforce order of evaluation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D12

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values.

wyt updated this revision to Diff 443868. wyt added a comment. Update CMakeList for DebugSupportTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values.

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun, mgorny. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Depends On D129546 <