[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Abandon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 _

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added a comment. In D129448#3669296 , @vitalybuka wrote: > I am not sure what to do with this patch. I really prefer to avoid it to > minimize the risk of regressions. > > We probably considered/prototyped to insert starts like in this soluti

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. I am not sure what to do with this patch. I really prefer to avoid it to minimize the risk of regressions. We probably considered/prototyped to insert starts like in this solution then in 2016. But at the time of the solution was a comment by @rsmith https://reviews

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 StephenFan wrote: > vitalybuka wrote: > > It assume this will break Msan > > Tr

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > vitalybuka wrote: > > StephenFan wrote: > > > vitalybuka wrote: > > > > vitalybuka wrote: > > > > > Please check for lifeti

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 445420. StephenFan added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. 1. Rebase. 2. Add a test case of goto_bypass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/ne

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > StephenFan wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > > > Please check for lifetime markers, I assume case 2

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); StephenFan wrote: > vitalybuka wrote: > > vitalybuka wrote: > > > Please check for lifetime markers, I assume case 2 will have a new one > > >

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 vitalybuka wrote: > It assume this will break Msan > Transforms/Instrumentation

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 444701. StephenFan added a comment. 1. Record bypassed lifetime start markers in codegenfunction class instead of lexicalscope. Since bypassed variables may be defined when lexicalscope is nullptr. This can also fix test fail of use-after-scope-goto.cpp.

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > Please check for lifetime markers, I assume case 2 will have a new one > Please check for lifetime markers, I assume case 2

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:935 SmallVector Labels; +SmallVector LifetimeStartMarkers; LexicalScope *ParentScope; LifetimeStartMarkers -> BypassedLifetimeStartMarkers and below if I read this co

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. looks like check-asan tests fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan created this revision. StephenFan added reviewers: MaskRay, vitalybuka, rsmith. Herald added a project: All. StephenFan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/56356 For fol