[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

2022-07-06 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8e2742d958: [pseudo] Define recovery strategy as grammar extension. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

2022-07-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:54 + return { + {(ExtensionID)Extension::Brackets, recoverBrackets}, + }; hokein wrote: > btw, it is annoying to write an expl

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

2022-07-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:46 + assert(Begin > 0); + const Token &Left = Tokens.tokens()[Begin - 1]; + if (const Token *Right = Left.pair())

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

2022-07-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm