[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47bdf53a5dba: [clang-format] Break on AfterColon only if not followed by comment (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

owenpan added a comment. In D129057#3627748 , @curdeius wrote: > LGTM. Thanks for addressing my comments. Thank you for your quick review and good comments as always! Comment at: clang/unittests/Format/FormatTest.cpp:7136

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129057/new/ https://reviews.llvm.org/D129057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing my comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129057/new/ https://reviews.llvm.org/D129057 __

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

owenpan updated this revision to Diff 442016. owenpan added a comment. Handle `PackContructorInitializers: NextLine` and address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129057/new/ https://reviews.llvm.org/D129057 Files: clang/lib/Format/ContinuationIndenter.cp

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7136 Style); + verifyFormat("Constructor() : // NOLINT\n" + "() {}", How about very long comments? They don't get split now? Please add a

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7099 OnePerLine); - verifyFormat("SomeClass::Constructor() :\n" + verifyFormat("SomeClass::Constructor() : // NOLINT\n" "a(aa),

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Break after a