[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-30 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf22795de683d: [Interpreter] Pass target features to JIT (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D128853?vs=44115

[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-30 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:34 struct PartialTranslationUnit; +struct TargetInfo; That's wrong, should be `class TargetInfo`. I'll fix this before landing if my other tests go well... Repository:

[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-29 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853

[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-29 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D128853#3620342 , @v.g.vassilev wrote: > Looks good to me but can we add a test? Do we have builders with that target? In principle, this is visible in *every* usage of `clang-repl`, including the existing tests such as `cl

[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-29 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Looks good to me but can we add a test? Do we have builders with that target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853 ___

[PATCH] D128853: [Interpreter] Pass target features to JIT

2022-06-29 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c