This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfc46d6e67fab: [clang][Tooling] Add support for generating
#import edits (authored by dgoldman).
Changed prior to commit:
https://reviews.llvm.org/
dgoldman updated this revision to Diff 480524.
dgoldman marked 2 inline comments as done.
dgoldman added a comment.
Use raw string literal
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128677/new/
https://reviews.llvm.org/D128677
Files:
clang-to
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:77
+TEST_F(HeaderIncludesTest, DeleteImportAndSameInclude) {
+ std::string Code = "#include \"abc.h\"\
dgoldman added inline comments.
Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:65
+TEST_F(HeaderIncludesTest, InsertImportWithSameInclude) {
+ std::string Code = "#include \"a.h\"\n";
kadircet wrote:
> can you also add a removal test?
>
> i know w
dgoldman updated this revision to Diff 480482.
dgoldman marked 9 inline comments as done.
dgoldman added a comment.
Fixes for review + fix diffbase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128677/new/
https://reviews.llvm.org/D128677
Files:
kadircet added a comment.
thanks, mostly LG. some small changes.
Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:261
if (Symbol.empty())
+F.Message = llvm::formatv("{0} {1}",
nit: `llvm::StringLiteral DirectiveSpelling = Directive ==
tooling::In
dgoldman updated this revision to Diff 479665.
dgoldman added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128677/new/
https://reviews.llvm.org/D128677
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clang
