This revision was automatically updated to reflect the committed changes.
Closed by commit rG141ad3ba0571: [clang-format] Fix uninitialized memory
problem (authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128607/new/
https://review
owenpan accepted this revision.
owenpan added a comment.
Can you remove NFC? IMO, fixing a memory error is not NFC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128607/new/
https://reviews.llvm.org/D128607
sstwcw added a comment.
This problem was found by the build bot after I pushed the buggy code.
https://lab.llvm.org/buildbot#builders/5/builds/25268
It looks like uninitialized memory was not checked when I ran `ninja
check-clang-format` locally. Am I missing some configuration?
Repository:
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The setLength function checks for the token kin