This revision was automatically updated to reflect the committed changes.
HazardyKnusperkeks marked an inline comment as done.
Closed by commit rGb3aeca3962bb: [clang-format] Further improve requires clause
detection (authored by HazardyKnusperkeks).
Repository:
rG LLVM Github Monorepo
CHANGES
HazardyKnusperkeks marked 4 inline comments as done.
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3185-3188
- default:
-// It's an expression.
-parseRequiresExpression(RequiresToken);
-return false;
c
HazardyKnusperkeks updated this revision to Diff 439689.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128496/new/
https://reviews.llvm.org/D128496
Files:
clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/TokenAnnotatorTest.cpp
Index: clang/unittests/Format/TokenAnnot
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM with Owen's suggestion.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3185-3188
- default:
-// It's an expression.
-parseRequiresExpression(RequiresT
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163-3169
+ default:
+if (!PreviousNonComment->isTypeOrIdentifier()) {
+ // It's an expression.
+ parseRequiresExpression(RequiresToken);
+ return false;
+}
+LLVM_FALLT
HazardyKnusperkeks created this revision.
HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan.
HazardyKnusperkeks added a project: clang-format.
Herald added a project: All.
HazardyKnusperkeks requested review of this revision.
Herald added a project: clang.
Herald added a subscri
