[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65a3bffd31f: [clang-tidy] Don't treat invalid branches as identical (authored by ishaangandhi, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Sure! Ishaan Gandhi ishaangandhi AT gmail DOT com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. Please provide the name and email address you wish to use on the commit and I will submit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

njames93 added a comment. In D128402#3621002 , @ishaangandhi wrote: > Once you see it, can you either confirm `-fix-errors` was correct originally, > or instruct me on how to fix this test failure? `-expect-clang-tidy-error` is the technically correct

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. I remember now, @njames93 : Without the `-fix-errors`, the test fails as follows: Command Output (stdout): -- Running ['clang-tidy', '/var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/bra

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 441192. ishaangandhi added a comment. Remove `-fix-errors` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. I can submit after you address additional comments by Nathan James. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/branch-clone-unknown-expr.cpp:1 +// RUN: %check_clang_tidy -fix-errors %s bugprone-branch-clone %t + is -fix-errors necessary here, given we aren't verifying any fixi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. Does anybody on this thread have land permissions? If not, would anyone know who to tag? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mailing list cf

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added a comment. @LegalizeAdulthood Thanks! I don't have commit rights to the repository, can you commit it on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits mail

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 440071. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Rebase against main to get updated docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added a comment. OK, I've pushed the link fix and the sorting fix to main so if you rebase again, it should just show your changes to the release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:221-224 +- Fixed a crash in :doc:`performance-unnecessary-value-param + ` when the specialization + template has an unnecessary value parameter. Removed the fix for a template. + -

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439596. ishaangandhi added a comment. Alphabetize some more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > Eugene.Zelenk

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote: > > Eugene.Zelenko wrote: > > > ishaangandhi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439501. ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Change doc path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/Bran

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > Eugene.Zelenk

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi marked an inline comment as done. ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > ishaangandhi wrote

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439488. ishaangandhi added a comment. Alphabetize release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:237 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches + involve unknown expressions. This link is wrong, needs to use the `bugprone/` direc

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Eugene.Zelenko wrote: > > > ishaangandh

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > ishaangandhi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > ishaangandhi wrote: > > Eugene.Zelenko wrote: > > > Documentation

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439369. ishaangandhi added a comment. Use `auto` instead of `Expr` and `llvm::cast` instead of `llvm::dyn_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/b

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Documentation path was changed recently.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:28 +const Expr *RHSExpr = llvm::dyn_cast(RHS); +if (LHSExpr->containsErrors() && RHSExpr->containsErrors()) { + return false; njames93 wrote: >

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:26 +// of the left and right statements. +const Expr *LHSExpr = llvm::dyn_cast(LHS); +const Expr *RHSExpr = llvm::dyn_cast(RHS); Eugene.Zelenko wrot

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:26 +// of the left and right statements. +const Expr *LHSExpr = llvm::dyn_cast(LHS); +const Expr *RHSExpr = llvm::dyn_cast(RHS); `auto` could

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439239. ishaangandhi added a comment. Include `error: ` in error line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439228. ishaangandhi added a comment. Check for error messages in test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439226. ishaangandhi added a comment. Move test to new file with `-fix-errors` flag CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439221. ishaangandhi added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/docs/ReleaseNotes.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ishaangandhi requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The clang-tidy check `bugprone-branch-clone` has a