[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3614242 , @thakis wrote: > Looks like this breaks check-clang on windows: > http://45.33.8.238/win/61067/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks. Added a2095d1aff84

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

thakis added a comment. Looks like this breaks check-clang on windows: http://45.33.8.238/win/61067/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://rev

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rGdacfa24f75c3: Delete 'llvm.asan.globals' for global metadata. (authored by hctim). Changed prior to commit:

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439918. hctim marked 3 inline comments as done. hctim added a comment. Vitaly's comments, round 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/Co

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address | Sanit

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added a comment. The rest is LGTM Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439912. hctim marked 2 inline comments as done. hctim added a comment. Vitaly's comments - round 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/C

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(;

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(; was this demanded before? ==

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 439880. hctim added a comment. Rebase on main / landed changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. In D127911#3605774 , @MaskRay wrote: >> This saves about ~0.275% of the optimised clang binary. > > Worth clarifying a bit which -O level and whether -g is used. `clang-15` binary, no `-g`, `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_BUI

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

MaskRay added a comment. > This saves about ~0.275% of the optimised clang binary. Worth clarifying a bit which -O level and whether -g is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 __

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim added a comment. friendly ping @vitalybuka Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 437385. hctim added a comment. Small test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/SanitizerM

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.