[PATCH] D127802: [HLSL] Support HLSL vector initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f499d9d73ed: [HLSL] Support HLSL vector initializers (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127802/new/ https://reviews.llvm.org/D127802

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz updated this revision to Diff 437670. beanz added a comment. Updates based on feedback from @aaron.ballman. Thank you for all the test suggestions, it caught an extra-odd AST generation. Fix included :). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:12 + float3 BrokenNormie = float3(3.0, 4.0); // expected-error{{too few elements in vector initialization (expected 3 elements, have 2)}} + float3 OverwhemledNormie = f

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:12 + float3 BrokenNormie = float3(3.0, 4.0); // expected-error{{too few elements in vector initialization (expected 3 elements, have 2)}} + float3 OverwhemledNormie = float3(3.

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} ---

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} aa

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5984 +for (unsigned Idx = 0; Idx < Elm; ++Idx) { + InitArgs.emplace_back(new (Context) ArraySubscriptExpr( + Arg, Huh, interesting -- I didn't realize we ha

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} py

[PATCH] D127802: [HLSL] Support HLSL vector initializers

python3kgae added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} -

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz created this revision. beanz added reviewers: aaron.ballman, kuhar, python3kgae, MaskRay. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. In HLSL vectors are ext_vectors in all respects exce