[PATCH] D127695: [clang] Implement Template Specialization Resugaring

2022-10-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I see, thank you. I know you've marked this a WIP, but it's always good to describe these things in the patch description; that's what it's for. This is quite exciting! Thank you for looking into this. I think you could usefully be much more incremental here. Obvious

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

2022-10-14 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. In D127695#3860237 , @rjmccall wrote: > What is this work about? I have written more about it in this discourse thread: https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294 Repo

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

2022-10-14 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. What is this work about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127695/new/ https://reviews.llvm.org/D127695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

2022-10-09 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. In D127695#3829020 , @davrec wrote: > The larger issues: > > 1. Performance - can we see some numbers? and There are still work left to do on a couple of enablers, and some other changes, in order to get performance on a level

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

2022-10-01 Thread David Rector via Phabricator via cfe-commits
davrec added a subscriber: rjmccall. davrec added a comment. First thank you for having separated out the public AST changes into other patches, it makes these mostly-Sema changes much easier to review. I don't see any major issues with the code, though this would benefit from a close look from