[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ca68d5845c0: [clang-tidy] Add `-verify-config` command line argument (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127446/new/ http

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added subscribers: kadircet, sammccall. njames93 added a comment. Before this lands @sammccall @kadircet Do you have any concerns about this API for getting the options not building a static instance here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown Check 'readability-else-after-ret'; did you mean 'readability-else-after-return' +// CHECK-V

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/verify-config.cpp:12 + +// CHECK-VERIFY-DAG: command-line option '-config': warning: Unknown Check 'readability-else-after-ret'; did you mean 'readability-else-after-return' +// CH

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:263 +Check the config files to ensure each check and +option is recognised. +)"), aaron.ballman wrote: > :) =

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 updated this revision to Diff 438953. njames93 marked an inline comment as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127446/new/ https://reviews.llvm.org/D127446 Files: clan

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

aaron.ballman added a comment. Thanks for this, it seems like an interesting feature! Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:263 +Check the config files to ensure each check and +option is recognised. +)"), Comment a

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 added a comment. In D127446#3572491 , @carlosgalvezp wrote: > This sounds like great functionality, surely saving a lot of headaches! Any > reason why we wouldn't want this active by default? I'd personally even go > one step further and make

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

carlosgalvezp added a comment. This sounds like great functionality, surely saving a lot of headaches! Any reason why we wouldn't want this active by default? I'd personally even go one step further and make it hard errors - warnings are easy to miss and ignore - but I can see how it can be pro

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.