[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc2c759aeee7: [analyzer] Fix assertion failure after getKnownValue call (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566032 , @steakhal wrote: > LGTM > Schedule a measurement to see what changes. Let's hope it won't introduce > more crashes. > If everything checks out, it gets approved. Results are good. No new assertion failures,

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether the SVal has only one possible + // (integer) value.

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether the SVal has only one possible + // (integer) value. If that is the case, the value is returned. Otherwise, + // returns NULL. + cons

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong updated this revision to Diff 435154. martong marked an inline comment as done. martong added a comment. - Add one more sentence in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://reviews.llvm.org/D127285 Fi

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566397 , @steakhal wrote: > In D127285#3566198 , @martong wrote: > >> In D127285#3566034 , @steakhal >> wrote: >> >>> ... Try to mark

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. In D127285#3566198 , @martong wrote: > In D127285#3566034 , @steakhal > wrote: > >> ... Try to mark named entities like `this`. > > Could you please elaborate? Oh sure. The `SimpleSValB

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566034 , @steakhal wrote: > ... Try to mark named entities like `this`. Could you please elaborate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://r

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. Check the summary for typos. Try to mark named entities like `this`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://reviews.llvm.org/D127285 ___ cfe-commits m

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. LGTM Schedule a measurement to see what changes. Let's hope it won't introduce more crashes. If everything checks out, it gets approved. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether t