[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rG958a88505080: [LinkerWrapper] Rework the linker wrapper and use owning binaries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/n

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I think this is probably OK. Smaller patches usually get reviewed faster so minimising the line noise in the browser is worthwhile. Comment at: clang/tools

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. In D127246#3599826 , @JonChesterfield wrote: > I've read it but can't promise it's correct - the diff is large and has some > spurious noise in it which distracts significantly from the functional > changes. > > Would you be w

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

JonChesterfield added a comment. I've read it but can't promise it's correct - the diff is large and has some spurious noise in it which distracts significantly from the functional changes. Would you be willing to split this into two patches, one which renames variables and moves blocks of cod

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 438758. jhuber6 added a comment. Adding a test to ensure we no longer write temporary files for unused inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files:

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. Is anyone up to review this? I'm mostly looking for some feedback on the interfaces I've built. If no one has time to look into it I can probably just land without review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1272

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435571. jhuber6 added a comment. Fixing bug when capturing a StringRef by reference in a callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files: clang/tool

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435124. jhuber6 added a comment. Sorry for this noise. This is a pretty large change but shouldn't affect any functionality and passes all the tests I know of, so this should be good to land. Let me know if you have any objections to how I've structured this

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435122. jhuber6 added a comment. Add use of bitcode libraries so this works on AMD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files: clang/tools/clang-linker-

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435118. jhuber6 added a comment. There was a problem where the Triple and Arch data would be deallocated when the LTO pass took ownership of every single file. Add a UniqueStringSaver to make sure they are still accessible after linking. Repository: rG L

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The linker wrapper currently eag