This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG835fcf2aa512: [clang][deps] Make order of module
dependencies deterministic (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGE
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
Thanks for explaining this, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127243/new/
https://reviews.llvm.org/D127243
__
benlangmuir updated this revision to Diff 435237.
benlangmuir added a comment.
Removed use of std::unique_ptr in DependencyScanningTool.cpp, per review
feedback.
@jansvoboda11 Note: there is another map containing
`std::unique_ptr` in `ModuleDepCollector`, but that one is required
for correct
benlangmuir added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:181
std::vector PrebuiltModuleDeps;
-std::map ClangModuleDeps;
+llvm::MapVector,
+llvm::StringMap>
jansvoboda11 wrote:
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:181
std::vector PrebuiltModuleDeps;
-std::map ClangModuleDeps;
+llvm::MapVector,
+llvm::StringMap>
What's the reason f
benlangmuir created this revision.
benlangmuir added reviewers: jansvoboda11, Bigcheese.
Herald added a subscriber: mgrang.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This fixes the underlying m
