This revision was automatically updated to reflect the committed changes.
jcranmer-intel marked an inline comment as done.
Closed by commit rGbf4923710333: [Clang] Enable -print-pipeline-passes in
clang. (authored by jcranmer-intel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
aeubanks added inline comments.
Comment at: clang/test/CodeGen/print-pipeline-passes.c:8
+// CHECK: always-inline
+// CHECK-SAME: verify
+void Foo(void) {}
jcranmer-intel wrote:
> aeubanks wrote:
> > aeubanks wrote:
> > > I believe this will fail in non-assert bu
jcranmer-intel marked 5 inline comments as done.
jcranmer-intel added inline comments.
Comment at: clang/test/CodeGen/print-pipeline-passes.c:8
+// CHECK: always-inline
+// CHECK-SAME: verify
+void Foo(void) {}
aeubanks wrote:
> aeubanks wrote:
> > I believe this
jcranmer-intel updated this revision to Diff 556574.
jcranmer-intel added a comment.
Replace verify with annotation-remarks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127221/new/
https://reviews.llvm.org/D127221
Files:
clang/lib/CodeGen/Backe
efriedma added a comment.
I don't really like `extern cl::opt PrintPipelinePasses;` (as opposed to
implementing a proper driver option that calls a proper API); secret handshakes
like this make it harder for people to write non-clang frontends. But I won't
block the patch just for that, I gues
aeubanks added inline comments.
Comment at: clang/test/CodeGen/print-pipeline-passes.c:8
+// CHECK: always-inline
+// CHECK-SAME: verify
+void Foo(void) {}
aeubanks wrote:
> I believe this will fail in non-assert builds
since we don't run the verifier in non-asse
aeubanks accepted this revision.
aeubanks added a comment.
lg with one test comment
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102
+outs() << "\n";
+return;
+ }
jcranmer-intel wrote:
> aeubanks wrote:
> > I wouldn't return here, doesn't seem right
jcranmer-intel updated this revision to Diff 556483.
jcranmer-intel added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127221/new/
https://reviews.llvm.org/D127221
Files:
clang/lib/CodeGen/BackendUtil.cpp
c
jcranmer-intel added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102
+outs() << "\n";
+return;
+ }
aeubanks wrote:
> I wouldn't return here, doesn't seem right that we'll skip running the opt
> pipeline but continue with compilation.
aeubanks added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1102
+outs() << "\n";
+return;
+ }
I wouldn't return here, doesn't seem right that we'll skip running the opt
pipeline but continue with compilation. we should either bail out
aaron.ballman added reviewers: efriedma, rjmccall.
aaron.ballman added a comment.
Adding codegen code owners as reviewers just so they're aware (I think you're
fine to land these changes if you don't hear back in the next day or two).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
jcranmer-intel updated this revision to Diff 556476.
jcranmer-intel added a comment.
Rebase to trunk.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127221/new/
https://reviews.llvm.org/D127221
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/tes
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.
I have no idea how you're supposed to work with clang without this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
jcranmer-intel created this revision.
Herald added a subscriber: ormris.
Herald added a project: All.
jcranmer-intel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D127221
Fi
14 matches
Mail list logo
