[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

NekoCdr added a comment. In D126960#4643979 , @AshleyRoll wrote: > If someone else wants to take it on, I'd be fine with that. You can resume working with this patch, if you want. It's just a reminder. ) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

AshleyRoll added a comment. I've not been able to get the time for a while, I hope to be able to spend some more time on it, but I'd probably do that through a GitHub PR now. If someone else wants to take it on, I'd be fine with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

NekoCdr added a comment. @AshleyRoll are you still working on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126960/new/ https://reviews.llvm.org/D126960 ___ cfe-commits mailing list cfe-commi

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

rsmith added a comment. Thank you for the patch! This is certainly an improvement but I think there are still some cases where we compute the wrong range for `~` with this patch applied. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(C, GetExprType(E)); +case UO_Not: erichkeane wrote: > Richard mentions UO_PreInc, UO_PreDec, UO_Minus, and UO_Not. What about the

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(C, GetExprType(E)); +case UO_Not: Richard mentions UO_PreInc, UO_PreDec, UO_Minus, and UO_Not. What about the other 3? ===

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

AshleyRoll updated this revision to Diff 434250. AshleyRoll added a comment. Rebased to remove clangd test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126960/new/ https://reviews.llvm.org/D126960 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

AshleyRoll created this revision. AshleyRoll added a reviewer: rsmith. Herald added a project: All. AshleyRoll requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I have modifyed GetExprRange() to capture the promotion of boolean values to ints