[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1f1b7240a3: [analyzer][NFC] Uplift checkers after D126801 (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://review

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://reviews.llvm.org/D126802 ___ cfe-commits mailing list cfe-commits

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

steakhal updated this revision to Diff 433737. steakhal marked 2 inline comments as done. steakhal added a comment. - replace `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126802/new/ https://reviews.llvm.org/D126802 Files: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

martong added a comment. I think we should avoid `auto` when using `State->get<>` because the type is not immediate for the reader. (Unlike in a `cast`.) Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp:198 // The special errno region should never garbage col

[PATCH] D126802: [analyzer][NFC] Uplift checkers after D126801

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. steak