[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire marked 3 inline comments as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:281 +void IncrementalParser::Restore(PartialTranslationUnit &PTU) { + TranslationUnitDecl *MostRecentTU = PTU.TUPart; v.g.vassilev

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 440027. junaire added a comment. Address @v.g.vassilev 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpret

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit &PTU); + v.g.vassilev wrote: > I am not sure if that's the best function. We Please ignore this comment it was superseded by

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. Thanks for working on this. Here are some more comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit &PTU); + I am not sure if that's the best function. We ==

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 439744. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Interpreter

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 438892. junaire added a comment. - Add unittest - Fix a crash when previous input failed to parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/inclu

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added reviewers: sgraenitz, lhames, rjmccall. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. I think we are in a good shape to broaden the list of reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436229. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Inte

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436219. junaire added a comment. Fix the unintentional format by clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436214. junaire added a comment. Address Vassil's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); junair

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); v.g.vassile

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435826. junaire added a comment. - split the tests - add % to all meta commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpret

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); We sho

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435782. junaire added a comment. Allow undo command failed in the edge cases like undoed too many times. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clan

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435781. junaire added a comment. Restore PTU in Interpreter::Undo, this should fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/in

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435779. junaire added a subscriber: Purva-Chaudhari. junaire added a comment. Merge D126684 into this patch. Consider D126684 is almost @Purva-Chaudhari 's work, I'll list her as co-author

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. In D126682#3546865 , @junaire wrote: > this depends on https://reviews.llvm.org/D126684 I would prefer to merge them into one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added a comment. this depends on https://reviews.llvm.org/D126684 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 ___ cfe-commits mailing list cfe-commi