PRESIDENT810 updated this revision to Diff 434690.
PRESIDENT810 added a comment.
More refactoring following Johannes's suggestion
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126651/new/
https://reviews.llvm.org/D126651
Files:
clang/lib/Tooling/ASTDiff/ASTDiff.cpp
clang/test/Tooli
johannes requested changes to this revision.
johannes added a comment.
This revision now requires changes to proceed.
I've suggested some more refactorings but otherwise this should be good to go
Comment at: clang/lib/Tooling/ASTDiff/ASTDiff.cpp:497
+ return str;
+}
PRESIDENT810 updated this revision to Diff 433375.
PRESIDENT810 added a comment.
Refactored some code and add support of U16 & U32 characters, as well as tests
for them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126651/new/
https://reviews.llvm.org/D126651
Files:
clang/lib/Tooli
johannes requested changes to this revision.
johannes added a comment.
This revision now requires changes to proceed.
I wonder if clang-diff is useful in its current state, I remember there are
many edge cases left over.
Anyway, I've left some minor comments. I'm not sure how to download a patch
PRESIDENT810 created this revision.
PRESIDENT810 added reviewers: klimek, arphaman, johannes.
Herald added a project: All.
PRESIDENT810 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This fixes https://github.com/llvm/llvm-project/issues/5
