[PATCH] D126578: [clang] Add tests for (const) weak variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86f9cf88cb06: [clang] Add tests for (const) weak variables (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.

[PATCH] D126578: [clang] Add tests for (const) weak variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.llvm.org/D126578

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders added a comment. In D126578#3543994 , @aaron.ballman wrote: > Thanks for looking to improve our test coverage here! However, precommit CI > looks to be failing: Thanks for notifying me. It should be green now. Repository: rG LLVM Github Mo

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders updated this revision to Diff 432742. wanders added a comment. Added explicit triple to hopefully make it pass on win. Made the new files clang-format clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.llvm.org

[PATCH] D126578: [clang] Add tests for (const) weak variables

aaron.ballman added a comment. Thanks for looking to improve our test coverage here! However, precommit CI looks to be failing: Failed Tests (1): Clang :: CodeGenCXX/weak-init.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D126578: [clang] Add tests for (const) weak variables

wanders created this revision. wanders added a reviewer: aaron.ballman. Herald added a project: All. wanders requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds tests checking the behavior of const variables declared with weak attribu