[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-08 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Thanks for the report. I am looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-08 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. New assertion failure: llvm-project/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:72: bool isLeftShiftResultUnrepresentable(const clang::BinaryOperator *, clang::ento::CheckerContext &): Assertion `LHS && RHS && "Values unknown, inconsistent state"' faile

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-06 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66f4d3b07b2: [analyzer] Track assume call stack to detect fixpoint (authored by martong). Changed prior to commit: https://reviews.llvm.org/D1265

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-06 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Measurement results on the last diff looks good. F23339447: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Express why this is not an NFC patch in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-commits@

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-02 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 433719. martong marked 3 inline comments as done. martong edited the summary of this revision. martong added a comment. - Add LLVM_UNLIKELY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://revi

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

2022-06-02 Thread Gabor Marton via Phabricator via cfe-commits
martong marked 4 inline comments as done. martong added a comment. > Consequently, a SmallPtrSet with 4 as the small buffer size would be better > than the SmallVector Ahh, SmallVector is still better, because with the set we need to do a search in the `erase, which compares badly to a simple d