This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb166aa833e44: [RISCV][NFC] Change interface of
RVVIntrinsic::getSuffixStr (authored by kito-cheng).
Repository:
rG LLVM Github Monorepo
CHANGES S
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125893/new/
https://reviews.llvm.org/D125893
___
kito-cheng updated this revision to Diff 430911.
kito-cheng added a comment.
Changes:
- Apply @craig.topper's suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125893/new/
https://reviews.llvm.org/D125893
Files:
clang/include/clang/Supp
craig.topper added inline comments.
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:346
+ getSuffixStr(BasicType Type, int Log2LMUL,
+ const llvm::ArrayRef
&PrototypeDescriptors);
};
Drop the `const` and the reference
Repository:
kito-cheng updated this revision to Diff 430391.
kito-cheng added a comment.
Changes:
- clang-format has applied on unexpected part, remove that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125893/new/
https://reviews.llvm.org/D125893
Files:
kito-cheng updated this revision to Diff 430390.
kito-cheng added a comment.
Changes:
- Fix dumb typo...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125893/new/
https://reviews.llvm.org/D125893
Files:
clang/include/clang/Support/RISCVVIntrins
kito-cheng created this revision.
kito-cheng added a reviewer: khchen.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,
