rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Prazek updated this revision to Diff 33969.
http://reviews.llvm.org/D12580
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
===
--- test/CodeGenCXX
Prazek added a comment.
I see that CGObjCMac.cpp names it like this:
"Objective-C Garbage Collection"
http://reviews.llvm.org/D12580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Functionally LGTM, but please add a test case. Is there any precedent for how
to spell these module flags (StrictVTablePointers / strict_vtable_pointers /
strict.vtable.pointers)?
http://reviews.llvm.org/D12580
___
cfe-comm
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky.
Prazek added a subscriber: cfe-commits.
Generates code like this
!llvm.module.flags = !{!0, !1}
!0 = !{i32 1, !"StrictVTablePointers", i32 1}
!1 = !{i32 3, !"StrictVTablePointersRequirement", !2}
!2 = !{!
