[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov added a comment. In D125742#3563855 , @ppluzhnikov wrote: > Could you commit this? Sure! Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 __

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rGafbe3aed4986: [clangd] Minor refactor of CanonicalIncludes::addSystemHeadersMapping. (authored by ppluzhnikov, committed by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Could you commit this? I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Comments addressed in new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov updated this revision to Diff 434828. ppluzhnikov marked 4 inline comments as done. ppluzhnikov added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 Files:

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov added a comment. Sorry about the delay. Thanks for the cleanup! I only have a few minor comments here. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:762 + static const auto *SystemHeaderMap = [] { +const int Size = sizeof(IncludeMappings)

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Ping x2? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov created this revision. ppluzhnikov added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Be