[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

2022-05-13 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looking at that error some more, it must've been D125429 . Moving the comment over there, sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125422/new/ https://reviews.llv

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

2022-05-13 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Hello, one of your three commits in https://github.com/llvm/llvm-project/compare/562ce1592456...d2396d896ee1 broke building on mac: - http://45.33.8.238/macm1/35247/step_4.txtp - https://green.lab.llvm.org/green/job/clang-stage1-RA/ Please take a look, and revert for n

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

2022-05-13 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99d35826a043: Comment parsing: Specify argument numbers for some block commands (authored by aaronpuchert). Repository: rG LLVM Github Monorepo C

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

2022-05-11 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 428800. aaronpuchert added a comment. Add an AST test to check that we parse the arguments correctly. (We don't use them for diagnostics currently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125422/new

[PATCH] D125422: Comment parsing: Specify argument numbers for some block commands

2022-05-11 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The command traits have a member NumArgs for which all the parsing infr