[PATCH] D125272: [clang] Add -fcheck-new support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52c8f0bb20eb: [clang] Add -fcheck-new support (authored by heatd, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D125272

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 530755. heatd added a comment. Remove -S from the fcheck-new test RUN:, as requested by MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 Files: clang/include/c

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:3 +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 530617. heatd added a comment. Addressed MaskRay's feedback: Added a testcase that showcases the conditional calling of a constructor (due to new not being tagged nonnull) Kept the testcase with the simple _Znwm call Deleted the ATTR tags at the end Re

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:7 +// CHECK-NEXT: entry: +// CHECK-NEXT:[[CALL:%.*]] = call noalias noundef ptr @_Znwm(i64 noundef 4) #[[ATTR2:[0-9]+]] +// CHECK-NEXT:ret ptr [[CALL]] ` #[[ATTR2:[0-9]+]]`

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S -

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 517029. heatd added a comment. Update the test to work with tip (completely forgot, apologies) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 Files: clang/include/cl

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 517020. heatd added a comment. Address MaskRay's comments on Options.td, adjust the help message, rebase to current tip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4117 + if (const Arg *A = Args.getLastArg(OPT_fcheck_new)) +Opts.CheckNew = true; + heatd wrote: > MaskRay wrote: > > Use `CodeGenOpts<"CheckNew">` and avoid change to this

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4117 + if (const Arg *A = Args.getLastArg(OPT_fcheck_new)) +Opts.CheckNew = true; + MaskRay wrote: > Use `CodeGenOpts<"CheckNew">` and avoid change to this file. CodeGenOpts

[PATCH] D125272: [clang] Add -fcheck-new support

lebedev.ri resigned from this revision. lebedev.ri added a comment. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:3 +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s + jrtc27 wrote: > MaskRay wrote: > > Pl

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:3 +// RUN: %clang_cc1 -fcheck-new -triple x86_64-linux-gnu -S -disable-O0-optnone \ +// RUN: -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s + MaskRay wrote: > Please remove `opt`

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4117 + if (const Arg *A = Args.getLastArg(OPT_fcheck_new)) +

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3531836 , @heatd wrote: > In D125272#3515874 , @heatd wrote: > >> In D125272#3504113 , @heatd wrote: >> >>> Adjusted the driver code to u

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3515874 , @heatd wrote: > In D125272#3504113 , @heatd wrote: > >> Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the >> comment. > > Ping. Ping. Reposi

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added a comment. In D125272#3504113 , @heatd wrote: > Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the > comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 428433. heatd added a comment. Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 File

[PATCH] D125272: [clang] Add -fcheck-new support

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15440 + // + // However, -fcheck-new violates this possible assumption, so don't add + // NonNull when that is enabled. 'invalidates' or 'negates' are better words here. Repository: rG

[PATCH] D125272: [clang] Add -fcheck-new support

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5984 + if (Args.hasFlag(options::OPT_fcheck_new, options::OPT_fno_check_new, false)) +CmdArgs.push_back("-fcheck-new"); See `addOptInFlag` in this file. Com

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang -fcheck-new --target=x86_64-linux-gnu -emit-llvm -S %s -o - | opt -S -mem2reg | FileCheck %s +

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:73 - // RUN: %clang -### -S -fauto-profile=%S/Inputs/file.prof %s 2>&1 | FileCheck -check-prefix=CHECK-AUTO-PROFILE %s jrtc27 wrote: > Hmmm Huh, running clang-format on clang_f_opts.c m

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang -fcheck-new --target=x86_64-linux-gnu -emit-llvm -S %s -o - | opt -S -mem2reg | FileCheck %s --

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 428254. heatd added a comment. Re-did the test, deleted redundant minus line diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 Files: clang/include/clang/Basic/La

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang -fcheck-new -emit-llvm -S %s -o - -O2 | FileCheck %s + heatd wrote: > jrtc27 wrote: > >

[PATCH] D125272: [clang] Add -fcheck-new support

heatd added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang -fcheck-new -emit-llvm -S %s -o - -O2 | FileCheck %s + jrtc27 wrote: > Do you really wan

[PATCH] D125272: [clang] Add -fcheck-new support

jrtc27 added inline comments. Comment at: clang/test/CodeGenCXX/fcheck-new.cpp:2 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang -fcheck-new -emit-llvm -S %s -o - -O2 | FileCheck %s + Do you really want -O2 or do you

[PATCH] D125272: [clang] Add -fcheck-new support

heatd created this revision. Herald added a project: All. heatd requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Add -fcheck-new and -fno-check-new, from GCC, which make the compiler not assume pointers returned from operator new are