[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

2022-05-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG817550919e78: [Lex] Don't assert when decoding invalid UCNs. (authored by sammccall). Changed prior to c

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

2022-05-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/crash/bad-ucn.c:4 +// RUN: clang-pseudo -source=%s +A\U nit: this test seems duplicated with the one in

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

2022-05-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. With this and D125049 , I no longer get any low-hanging fuzzer crashes. (Though we're probably mostly fuzzing the lexer. Providing a list of tokens as a dictionaly may help) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

2022-05-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Currently if a lexically-valid UCN encodes an invalid codepoint, t