[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua marked 4 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *La

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426823. li.zhe.hua added a comment. Switch from implementing in the trasfer function to skipping `ExprWithCleanups`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426783. li.zhe.hua added a comment. Handle FullExprs in the transfer function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807 Files: clang/lib/Analysis/FlowSens

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *LastE = nullptr; xazax.hun wrote:

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *LastE = nullptr; li.zhe.hua wro

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *LastE = nullptr; sgatev wrote:

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78 +/// and integers in the framework. +static const Expr *ignoreParenImpCastsExceptToBool(const Expr *E) { + const Expr *LastE = nullptr; I don't recall wh

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426711. li.zhe.hua added a comment. Update test to treat the PointerToBool conversion as an opaque boolean expression, and test it as such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

ymandel added a comment. Thanks for the patch! Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1155 +// FIXME: Remove this test once it provides no additional test coverage. +TEST_F(FlowConditionTest, DoesNotAssertForImplicitCastToBool)

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426528. li.zhe.hua added a comment. Remove else after return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDa

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `IgnoreParenImpCasts` will remove