This revision was automatically updated to reflect the committed changes.
Closed by commit rG8477a0d769a0: [OpenMP] Allow compiling multiple target
architectures with OpenMP (authored by jhuber6).
Changed prior to commit:
https://reviews.llvm.org/D124721?vs=426521&id=427734#toc
Repository:
r
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313
+ if (BoundArch.empty())
+checkSystemForAMDGPU(Args, *this, Arch);
DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_march_EQ), Arch);
tra wrote:
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM in general.
Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313
+ if (BoundArch.empty())
+checkSystemForAMDGPU(Args, *this, Arch);
DAL->AddJoinedA
jhuber6 added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124721/new/
https://reviews.llvm.org/D124721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
jhuber6 added inline comments.
Comment at: clang/test/Driver/openmp-offload-gpu-new.c:56
+
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -ccc-print-bindings
-fopenmp \
+// RUN: -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa
-Xopenmp-target=nvptx64-nvidia-
tra added a comment.
Comment at: clang/test/Driver/openmp-offload-gpu-new.c:56
+
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -ccc-print-bindings
-fopenmp \
+// RUN: -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa
-Xopenmp-target=nvptx64-nvidia-cuda --
jhuber6 updated this revision to Diff 426521.
jhuber6 added a comment.
Changing slightly, I'm using the `getArgsForToolchain` to only get the
`--offload-arch` options for that toolchain. This lets us quality it with
options like `-Xopenmp-target=` so we can now specify architectures
per-toolcha
jhuber6 added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-a
saiislam added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-
jhuber6 added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-a
saiislam added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-
saiislam added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-
jhuber6 added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-a
saiislam added inline comments.
Comment at: clang/test/Driver/amdgpu-openmp-toolchain-new.c:6
// RUN: | FileCheck %s
+// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp
-fopenmp-targets=amdgcn-amd-amdhsa \
+// RUN: --offload-arch=gfx906
--libomptarget-
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, saiislam,
tianshilei1992, tra.
Herald added subscribers: kerbowa, guansong, jvesely.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1,
15 matches
Mail list logo
