martell added a comment.
> Is this testable?
Seems to me the only way to add this as a test would be to add bad code to
clang to purposely pass an empty LibPath argument.
This is probably something we do not want to do.
This is probably why Reid never asked me for one in the review.
Reposito
Is this testable?
On Nov 25, 2015 5:56 PM, "Martell Malone via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL254117: Driver: protect from empty -L args (authored by
> martell).
>
> Changed prior to
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
Is this testable?
Repository:
rL LLVM
http://reviews.llvm.org/D12466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254117: Driver: protect from empty -L args (authored by
martell).
Changed prior to commit:
http://reviews.llvm.org/D12466?vs=33510&id=41202#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12466
Fi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This looks fine, just make sure the indentation is right. Phab seems confused.
Repository:
rL LLVM
http://reviews.llvm.org/D12466
___
cfe-commits ma
yaron.keren added a comment.
I have never used OSX, Try to add one of the Apple clang developers as
reviewers, they know more than me about OSX.
My guess there should not be empty paths in in TC.getFilePaths(). That patch
seems only to sidestep the issue which will probably surface in other pl
martell created this revision.
martell added reviewers: rnk, yaron.keren.
martell added a subscriber: cfe-commits.
martell set the repository for this revision to rL LLVM.
Not quite sure if this is the proper way to fix this.
This is currently my work around when working from an OSX host though.
