This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG813e521e55b1: [AMDGPU] Add gfx11 subtarget ELF definition
(authored by Joe_Nash).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124536/new/
https://reviews.llvm.org/D124536
___
Joe_Nash updated this revision to Diff 425802.
Joe_Nash added a comment.
add requested docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124536/new/
https://reviews.llvm.org/D124536
Files:
clang/test/Misc/target-invalid-cpu-note.c
llvm/docs/A
kzhuravl requested changes to this revision.
kzhuravl added a comment.
This revision now requires changes to proceed.
Need to update processor table:
https://llvm.org/docs/AMDGPUUsage.html#processors
Need to update EF_AMDGPU_MACH_AMDGCN table:
https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amd
kzhuravl added a comment.
Looks like this change is missing doc updates?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124536/new/
https://reviews.llvm.org/D124536
___
cfe-commits mailing list
cfe-commit
foad accepted this revision.
foad added a reviewer: t-tye.
foad added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124536/new/
https://reviews.llvm.org/D124536
Joe_Nash created this revision.
Herald added subscribers: hsmhsm, foad, dexonsmith, kerbowa, rupprecht,
hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, emaste,
arsenm.
Herald added a reviewer: jhenderson.
Herald added a project: All.
Joe_Nash requested review of this revisi