This revision was automatically updated to reflect the committed changes.
Closed by commit rG0d6b574b8717: [HLSL] Adjust access specifier behavior
(authored by beanz).
Changed prior to commit:
https://reviews.llvm.org/D124487?vs=425678&id=425799#toc
Repository:
rG LLVM Github Monorepo
CHANG
beanz added inline comments.
Comment at:
clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1
-
-// This file intentionally uses a CRLF newlines!
-
-void foo() {
- int *x = 0;
-}
+
+// This file intentionally uses a CRLF newlines!
aaron.ballma
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from whitespace changes.
Comment at:
clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1
-
-// This file intentionally uses a CRL
beanz updated this revision to Diff 425678.
beanz added a comment.
Herald added a project: clang-tools-extra.
Updates based on PR feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124487/new/
https://reviews.llvm.org/D124487
Files:
clang-t
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1603
+def ext_hlsl_access_specifiers : ExtWarn<
+ "access specifiers are a clang HLSL extension">;
This also needs to go into a warning group.
MaskRay added inline comments.
Comment at: clang/test/ParserHLSL/access_specifiers.hlsl:8
+private:
+ // expected-note@+2 {{declared private here}}
+ // expected-note@+1 {{declared private here}}
May need tests for `protected:` and `public:`, and possibly for `
beanz created this revision.
beanz added reviewers: aaron.ballman, MaskRay, kuhar, rsmith.
Herald added subscribers: Anastasia, StephenFan.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
HLSL doesn't supp
