Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-03 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246818: [Static Analyzer] Remove sinks from nullability checks. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12445?vs=33728&id=33987#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-03 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Anna. http://reviews.llvm.org/D12445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-01 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 33728. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. Style fixes according to the review. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index: test/Analy

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-01 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:806 @@ -690,1 +805,3 @@ + ProgramStateRef State = C.getState(); + if (State->get()) zaks.anna wrote: > Maybe we should only check these at the time the bug is about

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-01 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166 @@ +165,3 @@ + /// report anything and turn off the check. + /// + /// When \p SuppressPath is set to true, no more bugs will be reported on this It is still no

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-09-01 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 33704. xazax.hun added a comment. Made sure that inlined defensive checks do not generate false positives. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index: test/Analysis/null

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:395 @@ +394,3 @@ + // reaped. + if (!State->get()) { +ProgramStateRef NewState = zaks.anna wrote: > Maybe you should only do this if there was at least one symbol

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun updated this revision to Diff 33501. xazax.hun marked 6 inline comments as done. xazax.hun added a comment. Addressed the comments. http://reviews.llvm.org/D12445 Files: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp test/Analysis/nullability.mm Index: test/Analysis/nullabili

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166 @@ +165,3 @@ + // nullability precondition is violated it will not report any bugs at all. + void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region, +

[PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

2015-08-28 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, krememek, jordan_rose. xazax.hun added a subscriber: cfe-commits. With this patch a nullability violation no longer generates a sink node, so it does not cause any coverage loss for other checkers. >From now on, it