[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj abandoned this revision. upsj added a comment. I think we should be able to do this without adding new matchers globally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://reviews.llvm.org/D124373 _

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj planned changes to this revision. upsj added a comment. I wasn't aware of that, sounds perfect, thanks! Then I'll put this on hold until I figure out if it's really necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. In D124373#3477996 , @upsj wrote: > This is part of my long-term goal to add support for forwarding parameters > and documentation for make_unique-like functions to clangd. To be fair, the > details are not entirely fleshe

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj added a comment. This is part of my long-term goal to add support for forwarding parameters and documentation for make_unique-like functions to clangd. To be fair, the details are not entirely fleshed out - for inlay hints (displaying parameter names inline), the entire function template i

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. Due to how expensive it is to instantiate all the templates from ASTMatchers.h, we typically don't add new matchers unless there's a need for them in-tree or they're expected to be generally useful to a number of out-of-tree matchers. Are you planning to make use

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj updated this revision to Diff 425487. upsj added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://reviews.llvm.org/D124373 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/A

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj created this revision. upsj added a reviewer: klimek. Herald added a project: All. upsj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is no (obvious to me) way to match pack expansions and parameter packs, so I added two match