Re: [PATCH] D12411: [PATCH] Expose AST language options to checkers

2015-08-27 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r246209. I plan to do a more thorough search of clang-tidy to see what else can make use of this feature, this just happened to be low-hanging fruit that I found today by accident. ~Aaron http://reviews

Re: [PATCH] D12411: [PATCH] Expose AST language options to checkers

2015-08-27 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good .Thanks for fixing this! BTW, there are other checks that use LangOpts in the check() method. IIRC, misc-use-override, google-readabiity-casting and maybe something else. We need t

[PATCH] D12411: [PATCH] Expose AST language options to checkers

2015-08-27 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, djasper. aaron.ballman added a subscriber: cfe-commits. Some of the checkers need to know what language options are enabled in order to behave sensibly. For instance, the modernize-use-nullptr checker should not suggest