djasper closed this revision.
djasper added a comment.
Submitted as r248254, thank you!
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm added a comment.
I don't have credentials to commit it, anybody could do it for me if the diff
is ok?
Thanks!
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
matto1990 accepted this revision.
matto1990 added a comment.
This revision is now accepted and ready to land.
Looks good to me now!
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
berenm marked 5 inline comments as done.
berenm added a comment.
http://reviews.llvm.org/D12369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm updated this revision to Diff 33783.
berenm added a comment.
Here it is, with the typos in comments corrected, and rebased over the latest
trunk.
Thanks for the review!
http://reviews.llvm.org/D12369
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: un
matto1990 requested changes to this revision.
matto1990 added a comment.
This revision now requires changes to proceed.
This looks much better than the code I wrote. If all the unit tests are
passing, the one change I can see to make is a misspelling in one of the
comments. The rest looks excell
djasper added a comment.
Adding Matt, the original author of the code. (also I don't have much time to
review this or the other patch today, but will try to finish before the end of
the week)
http://reviews.llvm.org/D12369
___
cfe-commits mailing
berenm added a comment.
I'm not entirely sure of what was going on, so I rewrote the code a bit, and
hopefully, more clearly.
Comment at: lib/Format/WhitespaceManager.cpp:218
@@ -217,3 +229,1 @@
- bool AlignedAssignment = false;
- int PreviousShift = 0;
for (unsigned i = S
berenm created this revision.
berenm added a reviewer: djasper.
berenm added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This simple test case (added to the unit tests) was failing to align,
apparently due to the ``method();`` on the last line:
```
int oneTwoThree = 123;
int on
