[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-29 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG643c9b22ef52: [OpenMP] Make generating offloading entries more generic (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-11 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D123460#3443925 , @tianshilei1992 wrote: > If we'd like it to be used by CUDA or other programming models, > `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than > that, the patch looks good to me. I

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-11 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. If we'd like it to be used by CUDA or other programming models, `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than that, the patch looks good to me.

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-10 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 421794. jhuber6 added a comment. Change constant to just be a string since it's all we use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 421764. jhuber6 added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123460/new/ https://reviews.llvm.org/D123460 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOp

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

2022-04-09 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.