[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG95f0f69441fb: [clangd] Handle the new Using TemplateName. (authored by hokein). Repository: rG LLVM Githu

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:82 bool VisitTemplateSpecializationType(TemplateSpecializationType *TST) { -add(TST->getTemplateName().getAsTemplateDecl()); // Primary template. +

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein updated this revision to Diff 423892. hokein added a comment. implement a pseudo-VisitTemplateName locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 Files: clang-tools-extra/clangd/FindTar

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein added a comment. In D123212#3461557 , @sammccall wrote: > (Would be great to land this in some form if you get a chance!) sure, I plan to land it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall added a comment. (Would be great to land this in some form if you get a chance!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 ___ cfe-commits maili

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:76 bool VisitTemplateSpecializationType(TemplateSpecializationType *TST) { +if (const auto *UTN = TST

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:446 Outer.add(RD, Flags); // add(Decl) will despecialize if needed. +else if (const auto *UTN = + TST->getTemplateName

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein updated this revision to Diff 422823. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123212/new/ https://reviews.llvm.org/D123212 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/Incl

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:446 Outer.add(RD, Flags); // add(Decl) will despecialize if needed. +else if (const auto *UTN = + TST->getTemplateName().getAsUsingTemplateName()) -

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

kadircet added a comment. thanks a lot for doing this! some drive-by comments Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:87 + // to handle the UsingTemplateName case. + bool TraverseTemplateName(TemplateName TN) { +if (const auto *UTN = TN.getAsUsingTemplateN

[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Add support