Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Accept to close
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Prazek marked an inline comment as done.
Prazek added a comment.
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
LGTM.
Comment at: lib/CodeGen/CGClass.cpp:1234
@@ -1233,1 +1233,3 @@
+static bool isInitilierOfDynamicClass(const CXXCtorInitializer *BaseInit) {
+ const Type *BaseType = BaseInit->getBaseClass();
"Initializer"
But I think you can j
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 33775.
http://reviews.llvm.org/D12312
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExprCXX.cpp
lib/Driver/Tools.cpp
lib/Frontend
Prazek marked 3 inline comments as done.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis());
+
rjmccall wrote:
> Prazek wrot
rjmccall added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis());
+
Prazek wrote:
> rjmccall wrote:
> > Pr
Prazek added inline comments.
Comment at: include/clang/Driver/Options.td:990
@@ -988,2 +989,3 @@
"value range">;
+def fstrict_vptrs: Flag<["-"], "fstrict-vptrs">, Group,
Flags<[CC1Option]>;
def fstrict_overflow : Flag<["-"], "fstrict-overflow">, Group;
-
On Thu, Aug 27, 2015 at 3:49 PM, John McCall wrote:
> rjmccall added inline comments.
>
>
> Comment at: include/clang/Driver/Options.td:990
> @@ -988,2 +989,3 @@
> "value range">;
> +def fstrict_vptrs: Flag<["-"], "fstrict-vptrs">, Group,
> Flags<[CC1Option]>;
> def
rjmccall added inline comments.
Comment at: include/clang/Driver/Options.td:990
@@ -988,2 +989,3 @@
"value range">;
+def fstrict_vptrs: Flag<["-"], "fstrict-vptrs">, Group,
Flags<[CC1Option]>;
def fstrict_overflow : Flag<["-"], "fstrict-overflow">, Group;
---
Prazek added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis());
+
rjmccall wrote:
> Should this just be in
rjmccall added a comment.
You should add a test that actually checks that your feature works.
Comment at: lib/CodeGen/CGClass.cpp:1279
@@ +1278,3 @@
+ if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized)
+CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXTh
Prazek added a comment.
@rsmith I wonder If we have to put invariant.group.barrier when we call regular
new expression
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky.
Prazek added a subscriber: cfe-commits.
Keep in mind, that I will not push it untill I will update GVN for using
!invariant.group metadata
http://reviews.llvm.org/D12312
Files:
include/clang/Driver/Opt
13 matches
Mail list logo
