[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added subscribers: jansvoboda11, vsapsai, Bigcheese. dexonsmith added a comment. In D123104#3443448 , @dexonsmith wrote: > I wonder if > https://github.com/apple/llvm-project/commit/67c70038bcc0d771e2e39c875ad7d69e329c7fc4 > could be related

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added a comment. In D123104#3439261 , @bnbarham wrote: > Looks like there's more changes required for modulemap-collision.m to > actually pass. I'll try figure those out when I have the time. Capturing `clang -check` error since the build log

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham abandoned this revision. bnbarham added a comment. Looks like there's more changes required for modulemap-collision.m to actually pass. I'll try figure those out when I have the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/ne

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham updated this revision to Diff 420678. bnbarham added a comment. Added a potential plan to remove the FileManager hacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/new/ https://reviews.llvm.org/D123104 Files: clang/include/clan

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); dexonsmith wrote: > benlangmuir wrote: > > This paramete

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); benlangmuir wrote: > This parameter could use a commen

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

benlangmuir accepted this revision. benlangmuir added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); This parameter co

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. (Forgot to click "accept".) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/new/ https://reviews.llvm.org/D123104

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added reviewers: benlangmuir, bruno. dexonsmith added a comment. This LGTM, with a couple of comments (on the comments!) inline. > Upstreamed from apple#llvm-project 72cf785051fb1b3ef22eee4dd33366e41a275981. Note, for some extra background: - This was out-of-tree because it seemed "h

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham created this revision. bnbarham added a reviewer: dexonsmith. Herald added a project: All. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prevent possible modulemap collisions by making sure to always use the looked-up fi