Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've made those changes and commit in r246548, along with an updated test case for ObjC++ that I had previously missed. http://reviews.llvm.org/D12301 ___ cfe-commits mailin

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Couple of thoughts, but LGTM. Comment at: lib/Sema/SemaExprMember.cpp:889 @@ +888,3 @@ +S = S->getParent(); + } while (S != S->getFnParent()); + return false; --

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman added a comment. In http://reviews.llvm.org/D12301#232100, @aaron.ballman wrote: > This patch completely reworks the way the warning is implemented by moving it > into the frontend instead of clang-tidy. Ping ~Aaron http://reviews.llvm.org/D12301 ___

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman updated this revision to Diff 33078. aaron.ballman added a comment. This patch completely reworks the way the warning is implemented by moving it into the frontend instead of clang-tidy. http://reviews.llvm.org/D12301 Files: include/clang/Basic/DiagnosticSemaKinds.td include/

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Tue, Aug 25, 2015 at 8:05 AM, Aaron Ballman wrote: > On Mon, Aug 24, 2015 at 7:42 PM, Richard Smith wrote: >> On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman >> wrote: >>> >>> On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith >>> wrote: >>> > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman >>> >

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 7:42 PM, Richard Smith wrote: > On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman > wrote: >> >> On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith >> wrote: >> > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman >> > wrote: >> >> >> >> aaron.ballman created this revision. >> >> a

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 3:36 PM, Aaron Ballman wrote: > On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith > wrote: > > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman > > wrote: > >> > >> aaron.ballman created this revision. > >> aaron.ballman added reviewers: alexfh, rsmith. > >> aaron.ballman add

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 6:29 PM, Richard Smith wrote: > On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman > wrote: >> >> aaron.ballman created this revision. >> aaron.ballman added reviewers: alexfh, rsmith. >> aaron.ballman added a subscriber: cfe-commits. >> >> Per [except.handle]p10, the handler

Re: [PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

On Mon, Aug 24, 2015 at 3:23 PM, Aaron Ballman wrote: > aaron.ballman created this revision. > aaron.ballman added reviewers: alexfh, rsmith. > aaron.ballman added a subscriber: cfe-commits. > > Per [except.handle]p10, the handler for a constructor or destructor > function-try-block cannot refer

[PATCH] D12301: [PATCH] New checker for UB in handler of a function-try-block

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, rsmith. aaron.ballman added a subscriber: cfe-commits. Per [except.handle]p10, the handler for a constructor or destructor function-try-block cannot refer to a non-static member of the object under construction. This pat