Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

2015-12-30 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 43802. EricWF added a comment. - Change ABI macro name to `_LIBCPP_ABI_LIST_REMOVE_NODE_POINTER_UB`. - Remove unnecessary variable pointed out in review. - Rename `__node_pointer_traits` to `__list_node_pointer_traits` to prevent name collisions. http://revi

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

2015-12-30 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Minor changes; other than that, LGTM. Comment at: include/__config:43 @@ -42,1 +42,3 @@ +// Fix undefined behavior in how std::list stores it's linked nodes. +#defin

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

2015-12-21 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Ping. http://reviews.llvm.org/D12299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

2015-12-11 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 42612. EricWF added a comment. Update with correct patch this time. http://reviews.llvm.org/D12299 Files: include/__config include/list Index: include/list === --- include/list +++ include/

Re: [PATCH] D12299: [libcxx] Fix for ALL undefined behavior in .

2015-12-11 Thread Eric Fiselier via cfe-commits
EricWF retitled this revision from "[libcxx] ABI-Breaking Fix for ALL undefined behavior in ." to "[libcxx] Fix for ALL undefined behavior in .". EricWF updated the summary for this revision. EricWF updated this revision to Diff 42557. EricWF added a comment. Ping. Originally I considered this c