[PATCH] D122965: Corrected A Command

2022-04-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D122965#3426446 , @ps-19 wrote: > Priyansh Singh > priyansh.singh...@gmail.com Thanks! I've landed on your behalf in aa19500a4c3a66058078f88b3a7dd7a9ad30be12

[PATCH] D122965: Corrected A Command

2022-04-04 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 marked an inline comment as done. ps-19 added a comment. Priyansh Singh priyansh.singh...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 ___ cf

[PATCH] D122965: Corrected A Command

2022-04-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122965#3426412 , @aaron.ballman wrote: > In D122965#3426403 , @ps-19 wrote: > >> Can anyone please review the patch? > > FYI: please only ping the patch after about a week has g

[PATCH] D122965: Corrected A Command

2022-04-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D122965#3426403 , @ps-19 wrote: > Can anyone please review the patch? FYI: please only ping the patch after about a week has gone by

[PATCH] D122965: Corrected A Command

2022-04-04 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 marked 2 inline comments as done. ps-19 added a comment. Can anyone please review the patch? Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": smeenai wrote: > ps-19 wrote: > > Comment Line No

[PATCH] D122965: Corrected A Command

2022-04-03 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 updated this revision to Diff 420104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122965/new/ https://reviews.llvm.org/D122965 Files: clang/test/CodeGen/c-unicode.c Index: clang/test/CodeGen/c-unicode.c ==

[PATCH] D122965: Corrected A Command

2022-04-03 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Thanks for the typo fix! Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": ps-19 wrote: > Comment Line No: 5 is // ALLOWED: "곎ss": i think "곎ss" in istake here, > according

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. In D122965#3424348 , @ps-19 wrote: > I seriously can not understand why x64_Debian build if failing for every > patch. I have ran clang-format command for every patch even multiple times. Repository: rG LLVM Github Monorepo C

[PATCH] D122965: Corrected A Command

2022-04-02 Thread Priyansh Singh via Phabricator via cfe-commits
ps-19 added a comment. I seriously can not understand why x64_Debian build if failing for every patch. Comment at: clang/test/CodeGen/c-unicode.c:5 int \uaccess = 0; // ALLOWED: "곎ss": // ALLOWED-NOT: "\uaccess": Comment Line No: 5 is // ALLOWED: "곎ss": i th