phosek abandoned this revision.
phosek added a comment.
This was broken up into a series of smaller changes which landed separately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122931/new/
https://reviews.llvm.org/D122931
___
phosek added inline comments.
Herald added a subscriber: Enna1.
Comment at: compiler-rt/CMakeLists.txt:513-515
+# Don't use libcxx if LLVM_ENABLE_PROJECTS does not enable it.
+set(COMPILER_RT_LIBCXX_PATH ${LLVM_EXTERNAL_LIBCXX_SOURCE_DIR})
+set(COMPILER_RT_LIBCXXABI_P
smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.
(clearing my queue while there are unaddressed comments)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122931/new/
https://reviews.l
ldionne added a comment.
I like this, however IMO it would be better to instead have something like
COMPILER_RT_CXX_LIBRARY="libc++|system-libc++|libstdc++|..."
That way, this can be extended to support other C++ libraries without having to
add new boolean options, and without forcing folks t
phosek updated this revision to Diff 419831.
phosek edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122931/new/
https://reviews.llvm.org/D122931
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
compiler-rt/CMakeL
phosek created this revision.
phosek added reviewers: ldionne, smeenai, beanz.
Herald added subscribers: abrachet, mgorny, dberris.
Herald added a project: All.
phosek requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald added subscribers: Sanitizers, cfe-commits.
co
