[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik abandoned this revision. philnik added a comment. I'm dropping this in favour of D151683 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 ___

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik planned changes to this revision. philnik added a comment. This is useless until we have some `no_unique_address` in clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 _

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3442887 , @ldionne wrote: > I actually think that `[[no_unique_address]]` and > `__attribute__((no_unique_address))` should be equivalent. Similarly, we > should be able to do `[[msvc::no_unique_address]]` and

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

ldionne added a comment. I actually think that `[[no_unique_address]]` and `__attribute__((no_unique_address))` should be equivalent. Similarly, we should be able to do `[[msvc::no_unique_address]]` and `__attribute__((msvc::no_unique_address))`, and both should be equivalent. Which one we pic

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. > Hmmm, I'd be more comfortable if this wasn't an ABI break for people using > the `__attribute__(())` spelling. If we wanted to surprise users with ABI > breaks, we'd just implement `[[no_unique_address]]` on Windows and break > users when Microsoft eventually supports

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

RKSimon resigned from this revision. RKSimon added a comment. Sorry but this is not an area I know enough about to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 __

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3430672 , @philnik wrote: >> And if `[[msvc::no_unique_address]]` and `[[no_unique_address]]` (when >> eventually implemented) in MSVC have a different ABI impact, will we will >> leave `__attribute__((no_unique

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a subscriber: ldionne. philnik added a comment. > And if `[[msvc::no_unique_address]]` and `[[no_unique_address]]` (when > eventually implemented) in MSVC have a different ABI impact, will we will > leave `__attribute__((no_unique_address))` alone so it won't break ABI? I think th

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3422489 , @philnik wrote: > In D122874#3422263 , @aaron.ballman > wrote: > >> I'm not opposed, but this does muddy the waters about the target-specific >> nature of the

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. In D122874#3422263 , @aaron.ballman wrote: > I'm not opposed, but this does muddy the waters about the target-specific > nature of the attribute. Currently, the semantic attribute cannot be used > outside of Itanium ABI targets

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. I'm not opposed, but this does muddy the waters about the target-specific nature of the attribute. Currently, the semantic attribute cannot be used outside of Itanium ABI targets, so it doesn't work on Windows (and we don't want it to -- Microsoft hasn't picked th

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik created this revision. philnik added reviewers: aaron.ballman, rsmith, RKSimon. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ wants to switch from `__compressed_pair` to using `no_unique