[PATCH] D122831: [OpenMP] Make the new offloading driver the default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae23be84cb60: [OpenMP] Make the new offloading driver the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423433. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D122831 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks! If it fails CI we might want to submit the tests and the code change separately, but I'm fine with trying it as one block in the first instance. Repository:

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423416. jhuber6 added a comment. Herald added a subscriber: mattd. Splitting major changes into two files as per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D1

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

JonChesterfield added a comment. Editing the tests in place to check for new driver properties would mean we lose coverage for the old driver and get a lot of churn if we need to back out the change. How about taking some of the more interesting driver tests, duplicating them to only run the n

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 added a comment. In D122831#3419768 , @jdoerfert wrote: > I feel we should port some of the clang driver tests rather than running them > only for the old one. > The old one is on its way out, so ... I tried to keep it where it worked, most of t

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jdoerfert added a comment. I feel we should port some of the clang driver tests rather than running them only for the old one. The old one is on its way out, so ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, grokos, ABataev, ronlieb, tianshilei1992, saiislam. Herald added subscribers: asavonic, kerbowa, guansong, yaxunl, mgorny, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald add