[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419970. cor3ntin added a comment. - Add codegen test - Fixed a typo that caused openmp test failures - Cleanups & formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419880. cor3ntin added a comment. Try to rerun the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertU

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419765. cor3ntin added a comment. Add a diagnostic in openmp mode. Supporting structured bindings in OpenMP mode requires OpenMP expertise, so we emit a diagnostic in -fopenmp mode informing that feature is not supported yet. My idea is that whether and how

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419710. cor3ntin added a comment. Fix typo in test, fix captureInLambda (was crashing in release and not debug) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419657. cor3ntin added a comment. - formatting - add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopC

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419650. cor3ntin added a comment. Fix tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp c

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointer

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419281. cor3ntin added a comment. Remote commented-out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConve

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin added a comment. This is not quite mature. I think it needs a few more tests, notably codegen tests which I'm not sure how to write properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768